thomas.nuyken/vegasco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update packages, use explicit type, use Microsoft OpenApi package

Browse Source
This commit is contained in:
Thomas Nuyken
2025-06-12 17:43:22 +02:00
parent b3ca1ba703
commit d91b837e44
32 changed files with 138 additions and 230 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/WebApi.Tests.Integration/Cars/CreateCarTests.cs
View File

@@ -28,10 +28,10 @@ public class CreateCarTests : IAsyncLifetime
public async Task CreateCar_ShouldCreateCar_WhenRequestIsValid()
{
// Arrange
var createCarRequest = _carFaker.CreateCarRequest();
CreateCar.Request createCarRequest = _carFaker.CreateCarRequest();
// Act
var response = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
HttpResponseMessage response = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
// Assert
response.StatusCode.Should().Be(HttpStatusCode.Created);
@@ -49,7 +49,7 @@ public class CreateCarTests : IAsyncLifetime
var createCarRequest = new CreateCar.Request("");
// Act
var response = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
HttpResponseMessage response = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
// Assert
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);

8
tests/WebApi.Tests.Integration/Cars/DeleteCarTests.cs
View File

@@ -30,7 +30,7 @@ public class DeleteCarTests : IAsyncLifetime
var randomCarId = Guid.NewGuid();
// Act
var response = await _factory.HttpClient.DeleteAsync($"v1/cars/{randomCarId}");
HttpResponseMessage response = await _factory.HttpClient.DeleteAsync($"v1/cars/{randomCarId}");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.NotFound);
@@ -40,13 +40,13 @@ public class DeleteCarTests : IAsyncLifetime
public async Task DeleteCar_ShouldDeleteCar_WhenCarExists()
{
// Arrange
var createCarRequest = _carFaker.CreateCarRequest();
var createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
CreateCar.Request createCarRequest = _carFaker.CreateCarRequest();
HttpResponseMessage createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
createCarResponse.EnsureSuccessStatusCode();
var createdCar = await createCarResponse.Content.ReadFromJsonAsync<CreateCar.Response>();
// Act
var response = await _factory.HttpClient.DeleteAsync($"v1/cars/{createdCar!.Id}");
HttpResponseMessage response = await _factory.HttpClient.DeleteAsync($"v1/cars/{createdCar!.Id}");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.NoContent);

8
tests/WebApi.Tests.Integration/Cars/GetCarTests.cs
View File

@@ -24,7 +24,7 @@ public class GetCarTests : IAsyncLifetime
var randomCarId = Guid.NewGuid();
// Act
var response = await _factory.HttpClient.GetAsync($"v1/cars/{randomCarId}");
HttpResponseMessage response = await _factory.HttpClient.GetAsync($"v1/cars/{randomCarId}");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.NotFound);
@@ -34,13 +34,13 @@ public class GetCarTests : IAsyncLifetime
public async Task GetCar_ShouldReturnCar_WhenCarExists()
{
// Arrange
var createCarRequest = _carFaker.CreateCarRequest();
var createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
CreateCar.Request createCarRequest = _carFaker.CreateCarRequest();
HttpResponseMessage createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
createCarResponse.EnsureSuccessStatusCode();
var createdCar = await createCarResponse.Content.ReadFromJsonAsync<CreateCar.Response>();
// Act
var response = await _factory.HttpClient.GetAsync($"v1/cars/{createdCar!.Id}");
HttpResponseMessage response = await _factory.HttpClient.GetAsync($"v1/cars/{createdCar!.Id}");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);

18
tests/WebApi.Tests.Integration/Cars/UpdateCarTests.cs
View File

@@ -28,15 +28,15 @@ public class UpdateCarTests : IAsyncLifetime
public async Task UpdateCar_ShouldUpdateCar_WhenCarExistsAndRequestIsValid()
{
// Arrange
var createCarRequest = _carFaker.CreateCarRequest();
var createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
CreateCar.Request createCarRequest = _carFaker.CreateCarRequest();
HttpResponseMessage createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
createCarResponse.EnsureSuccessStatusCode();
var createdCar = await createCarResponse.Content.ReadFromJsonAsync<CreateCar.Response>();
var updateCarRequest = _carFaker.UpdateCarRequest();
UpdateCar.Request updateCarRequest = _carFaker.UpdateCarRequest();
// Act
var response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{createdCar!.Id}", updateCarRequest);
HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{createdCar!.Id}", updateCarRequest);
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
@@ -54,15 +54,15 @@ public class UpdateCarTests : IAsyncLifetime
public async Task UpdateCar_ShouldReturnValidationProblems_WhenRequestIsNotValid()
{
// Arrange
var createCarRequest = _carFaker.CreateCarRequest();
var createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
CreateCar.Request createCarRequest = _carFaker.CreateCarRequest();
HttpResponseMessage createCarResponse = await _factory.HttpClient.PostAsJsonAsync("v1/cars", createCarRequest);
createCarResponse.EnsureSuccessStatusCode();
var createdCar = await createCarResponse.Content.ReadFromJsonAsync<CreateCar.Response>();
var updateCarRequest = new UpdateCar.Request("");
// Act
var response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{createdCar!.Id}", updateCarRequest);
HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{createdCar!.Id}", updateCarRequest);
// Assert
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
@@ -79,11 +79,11 @@ public class UpdateCarTests : IAsyncLifetime
public async Task UpdateCar_ShouldReturnNotFound_WhenNoCarWithIdExists()
{
// Arrange
var updateCarRequest = _carFaker.UpdateCarRequest();
UpdateCar.Request updateCarRequest = _carFaker.UpdateCarRequest();
var randomCarId = Guid.NewGuid();
// Act
var response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{randomCarId}", updateCarRequest);
HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/cars/{randomCarId}", updateCarRequest);
// Assert
response.StatusCode.Should().Be(HttpStatusCode.NotFound);

2
tests/WebApi.Tests.Integration/Consumptions/GetConsumptionTests.cs
View File

@@ -35,7 +35,7 @@ public class GetConsumptionTests : IAsyncLifetime
using HttpResponseMessage response = await _factory.HttpClient.GetAsync($"v1/consumptions/{createdConsumption.Id}");
// Assert
var content = await response.Content.ReadAsStringAsync();
string content = await response.Content.ReadAsStringAsync();
response.StatusCode.Should().Be(HttpStatusCode.OK);
var consumption = await response.Content.ReadFromJsonAsync<GetConsumption.Response>();
consumption.Should().BeEquivalentTo(createdConsumption);

6
tests/WebApi.Tests.Integration/Consumptions/UpdateConsumptionTests.cs
View File

@@ -37,7 +37,7 @@ public class UpdateConsumptionTests : IAsyncLifetime
using HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/consumptions/{createdConsumption.Id}", updateConsumptionRequest);
// Assert
var content = await response.Content.ReadAsStringAsync();
string content = await response.Content.ReadAsStringAsync();
response.StatusCode.Should().Be(HttpStatusCode.OK);
var updatedConsumption = await response.Content.ReadFromJsonAsync<UpdateConsumption.Response>();
updatedConsumption.Should().BeEquivalentTo(updateConsumptionRequest, o => o.ExcludingMissingMembers());
@@ -65,7 +65,7 @@ public class UpdateConsumptionTests : IAsyncLifetime
using HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/consumptions/{randomGuid}", updateConsumptionRequest);
// Assert
var content = await response.Content.ReadAsStringAsync();
string content = await response.Content.ReadAsStringAsync();
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
var validationProblemDetails = await response.Content.ReadFromJsonAsync<ValidationProblemDetails>();
validationProblemDetails!.Errors.Keys.Should().Contain(x =>
@@ -86,7 +86,7 @@ public class UpdateConsumptionTests : IAsyncLifetime
using HttpResponseMessage response = await _factory.HttpClient.PutAsJsonAsync($"v1/consumptions/{randomGuid}", updateConsumptionRequest);
// Assert
var content = await response.Content.ReadAsStringAsync();
string content = await response.Content.ReadAsStringAsync();
response.StatusCode.Should().Be(HttpStatusCode.NotFound);
_dbContext.Consumptions.Should().NotContainEquivalentOf(updateConsumptionRequest);

2
tests/WebApi.Tests.Integration/TestUserAlwaysAuthorizedPolicyEvaluator.cs
View File

@@ -26,7 +26,7 @@ public sealed class TestUserAlwaysAuthorizedPolicyEvaluator : IPolicyEvaluator
ClaimsIdentity identity = new(claims, JwtBearerDefaults.AuthenticationScheme);
ClaimsPrincipal principal = new(identity);
AuthenticationTicket ticket = new(principal, JwtBearerDefaults.AuthenticationScheme);
var result = AuthenticateResult.Success(ticket);
AuthenticateResult result = AuthenticateResult.Success(ticket);
return Task.FromResult(result); ;
}

24
tests/WebApi.Tests.Integration/WebApi.Tests.Integration.csproj
View File

@@ -10,21 +10,21 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.13.1" />
<PackageReference Include="Bogus" Version="35.6.1" />
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PackageReference Include="Azure.Identity" Version="1.14.0" />
<PackageReference Include="Bogus" Version="35.6.3" />
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="FluentAssertions" Version="8.3.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.5" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.5" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageReference Include="Respawn" Version="6.2.1" />
<PackageReference Include="System.Formats.Asn1" Version="9.0.0" />
<PackageReference Include="Testcontainers.PostgreSql" Version="4.1.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
<PackageReference Include="System.Formats.Asn1" Version="9.0.5" />
<PackageReference Include="Testcontainers.PostgreSql" Version="4.5.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
@@ -40,7 +40,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Update="Nerdbank.GitVersioning" Version="3.7.112" />
<PackageReference Update="Nerdbank.GitVersioning" Version="3.7.115" />
</ItemGroup>
</Project>

18
tests/WebApi.Tests.Unit/Authentication/UserAccessorTests.cs
View File

@@ -50,7 +50,7 @@ public sealed class UserAccessorTests
// Arrange
// Act
var result = _sut.GetUsername();
string result = _sut.GetUsername();
// Assert
result.Should().Be(_defaultUsername);
@@ -67,7 +67,7 @@ public sealed class UserAccessorTests
]));
// Act
var result = _sut.GetUsername();
string result = _sut.GetUsername();
// Assert
result.Should().Be(_defaultUsername);
@@ -81,7 +81,7 @@ public sealed class UserAccessorTests
_options.ClearReceivedCalls();
// Act
var result = _sut.GetUsername();
string result = _sut.GetUsername();
// Assert
result.Should().Be(_defaultUsername);
@@ -95,7 +95,7 @@ public sealed class UserAccessorTests
_httpContextAccessor.HttpContext = null;
// Act
var action = () => _sut.GetUsername();
Func<string> action = () => _sut.GetUsername();
// Assert
action.Should().ThrowExactly<InvalidOperationException>()
@@ -109,7 +109,7 @@ public sealed class UserAccessorTests
_httpContextAccessor.HttpContext!.User = new ClaimsPrincipal();
// Act
var action = () => _sut.GetUsername();
Func<string> action = () => _sut.GetUsername();
// Assert
action.Should().ThrowExactly<InvalidOperationException>()
@@ -126,7 +126,7 @@ public sealed class UserAccessorTests
// Arrange
// Act
var result = _sut.GetUserId();
string result = _sut.GetUserId();
// Assert
result.Should().Be(_defaultId);
@@ -140,7 +140,7 @@ public sealed class UserAccessorTests
_options.ClearReceivedCalls();
// Act
var result = _sut.GetUserId();
string result = _sut.GetUserId();
// Assert
result.Should().Be(_defaultId);
@@ -154,7 +154,7 @@ public sealed class UserAccessorTests
_httpContextAccessor.HttpContext = null;
// Act
var action = () => _sut.GetUserId();
Func<string> action = () => _sut.GetUserId();
// Assert
action.Should().ThrowExactly<InvalidOperationException>()
@@ -168,7 +168,7 @@ public sealed class UserAccessorTests
_httpContextAccessor.HttpContext!.User = new ClaimsPrincipal();
// Act
var action = () => _sut.GetUserId();
Func<string> action = () => _sut.GetUserId();
// Assert
action.Should().ThrowExactly<InvalidOperationException>()

15
tests/WebApi.Tests.Unit/Cars/CreateCarRequestValidatorTests.cs
View File

@@ -1,4 +1,5 @@
using FluentAssertions;
using FluentValidation.Results;
using Vegasco.WebApi.Cars;
namespace WebApi.Tests.Unit.Cars;
@@ -15,7 +16,7 @@ public sealed class CreateCarRequestValidatorTests
// Arrange
// Act
var result = await _sut.ValidateAsync(_validRequest);
ValidationResult? result = await _sut.ValidateAsync(_validRequest);
// Assert
result.IsValid.Should().BeTrue();
@@ -27,10 +28,10 @@ public sealed class CreateCarRequestValidatorTests
public async Task ValidateAsync_ShouldBeValid_WhenNameIsJustWithinTheLimits(int nameLength)
{
// Arrange
var request = _validRequest with { Name = new string('s', nameLength) };
CreateCar.Request request = _validRequest with { Name = new string('s', nameLength) };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeTrue();
@@ -40,10 +41,10 @@ public sealed class CreateCarRequestValidatorTests
public async Task ValidateAsync_ShouldNotBeValid_WhenNameIsEmpty()
{
// Arrange
var request = _validRequest with { Name = "" };
CreateCar.Request request = _validRequest with { Name = "" };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeFalse();
@@ -57,10 +58,10 @@ public sealed class CreateCarRequestValidatorTests
{
// Arrange
const int nameMaxLength = 50;
var request = _validRequest with { Name = new string('s', nameMaxLength + 1) };
CreateCar.Request request = _validRequest with { Name = new string('s', nameMaxLength + 1) };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeFalse();

15
tests/WebApi.Tests.Unit/Cars/UpdateCarRequestValidatorTests.cs
View File

@@ -1,4 +1,5 @@
using FluentAssertions;
using FluentValidation.Results;
using Vegasco.WebApi.Cars;
namespace WebApi.Tests.Unit.Cars;
@@ -15,7 +16,7 @@ public sealed class UpdateCarRequestValidatorTests
// Arrange
// Act
var result = await _sut.ValidateAsync(_validRequest);
ValidationResult? result = await _sut.ValidateAsync(_validRequest);
// Assert
result.IsValid.Should().BeTrue();
@@ -27,10 +28,10 @@ public sealed class UpdateCarRequestValidatorTests
public async Task ValidateAsync_ShouldBeValid_WhenNameIsJustWithinTheLimits(int nameLength)
{
// Arrange
var request = _validRequest with { Name = new string('s', nameLength) };
UpdateCar.Request request = _validRequest with { Name = new string('s', nameLength) };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeTrue();
@@ -40,10 +41,10 @@ public sealed class UpdateCarRequestValidatorTests
public async Task ValidateAsync_ShouldNotBeValid_WhenNameIsEmpty()
{
// Arrange
var request = _validRequest with { Name = "" };
UpdateCar.Request request = _validRequest with { Name = "" };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeFalse();
@@ -57,10 +58,10 @@ public sealed class UpdateCarRequestValidatorTests
{
// Arrange
const int nameMaxLength = 50;
var request = _validRequest with { Name = new string('s', nameMaxLength + 1) };
UpdateCar.Request request = _validRequest with { Name = new string('s', nameMaxLength + 1) };
// Act
var result = await _sut.ValidateAsync(request);
ValidationResult? result = await _sut.ValidateAsync(request);
// Assert
result.IsValid.Should().BeFalse();

14
tests/WebApi.Tests.Unit/WebApi.Tests.Unit.csproj
View File

@@ -10,16 +10,16 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="FluentAssertions" Version="8.3.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.5" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageReference Include="NSubstitute" Version="5.3.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
@@ -34,7 +34,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Update="Nerdbank.GitVersioning" Version="3.7.112" />
<PackageReference Update="Nerdbank.GitVersioning" Version="3.7.115" />
</ItemGroup>
</Project>