Compare commits

...

2 Commits

Author SHA1 Message Date
fd9b9c7c2e Fix copied texts
All checks were successful
continuous-integration/drone/push Build is passing
2025-06-19 15:04:27 +02:00
b6f9b5fb26 Remove unnecessary db roundtrip when deleting an entry 2025-06-19 15:04:09 +02:00
3 changed files with 28 additions and 19 deletions

View File

@@ -106,7 +106,7 @@ export class EntryCardComponent {
severity: 'error',
summary: 'Serverfehler',
detail:
'Beim Erstellen des Eintrags ist ein Fehler aufgetreten. Bitte versuche es erneut.',
'Beim Löschen des Eintrags ist ein Fehler aufgetreten. Bitte versuche es erneut.',
});
break;
case error.status === 400:
@@ -123,7 +123,7 @@ export class EntryCardComponent {
severity: 'error',
summary: 'Unerwarteter Fehler',
detail:
'Beim Erstellen des Eintrags hat der Server eine unerwartete Antwort zurückgegeben.',
'Beim Löschen des Eintrags hat der Server eine unerwartete Antwort zurückgegeben.',
});
break;
}

View File

@@ -1,4 +1,5 @@
using Vegasco.Server.Api.Persistence;
using Microsoft.EntityFrameworkCore;
using Vegasco.Server.Api.Persistence;
namespace Vegasco.Server.Api.Cars;
@@ -17,18 +18,21 @@ public static class DeleteCar
public static async Task<IResult> Endpoint(
Guid id,
ApplicationDbContext dbContext,
ILoggerFactory loggerFactory,
CancellationToken cancellationToken)
{
Car? car = await dbContext.Cars.FindAsync([new CarId(id)], cancellationToken: cancellationToken);
var rows = await dbContext.Cars
.Where(x => x.Id == new CarId(id))
.ExecuteDeleteAsync(cancellationToken);
if (car is null)
if (rows > 1)
{
return TypedResults.NotFound();
var logger = loggerFactory.CreateLogger(nameof(DeleteCar));
logger.LogWarning("Deleted '{DeletedRowCount}' rows for id '{CarId}'", rows, id);
}
dbContext.Cars.Remove(car);
await dbContext.SaveChangesAsync(cancellationToken);
return TypedResults.NoContent();
return rows > 0
? TypedResults.NoContent()
: TypedResults.NotFound();
}
}

View File

@@ -1,4 +1,5 @@
using Vegasco.Server.Api.Persistence;
using Microsoft.EntityFrameworkCore;
using Vegasco.Server.Api.Persistence;
namespace Vegasco.Server.Api.Consumptions;
@@ -15,19 +16,23 @@ public static class DeleteConsumption
}
private static async Task<IResult> Endpoint(
ApplicationDbContext dbContext,
Guid id,
ApplicationDbContext dbContext,
ILoggerFactory loggerFactory,
CancellationToken cancellationToken)
{
Consumption? consumption = await dbContext.Consumptions.FindAsync([new ConsumptionId(id)], cancellationToken);
if (consumption is null)
var rows = await dbContext.Consumptions
.Where(x => x.Id == new ConsumptionId(id))
.ExecuteDeleteAsync(cancellationToken);
if (rows > 1)
{
return TypedResults.NotFound();
var logger = loggerFactory.CreateLogger(nameof(DeleteConsumption));
logger.LogWarning("Deleted '{DeletedRowCount}' rows for id '{ConsumptionId}'", rows, id);
}
dbContext.Consumptions.Remove(consumption);
await dbContext.SaveChangesAsync(cancellationToken);
return TypedResults.NoContent();
return rows > 0
? TypedResults.NoContent()
: TypedResults.NotFound();
}
}